-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a note about full/trimmed ruby version in legacy file #101
Conversation
Do any version managers support the |
Yep, rvm does. It is mentioned in install docs https://rvm.io/rvm/basics#installing-rubies, under NOTE:
|
I'm looking at: https://rvm.io/workflow/projects And I do not see anything about |
It isn't explicitly mentioned in the docs, but gist you provided had some discussion on the matter. https://gist.github.com/fnichol/1912050#gistcomment-628554 (this and following 5-6 comments), https://gist.github.com/fnichol/1912050#gistcomment-804032, https://gist.github.com/fnichol/1912050#gistcomment-1315733. TL;DR is chruby supports fuzzy matching - any substring in .ruby-version will match rubies containt it, rvm supports specifying A little demonstration to confirm rvm supports this: $ mkdir -p /tmp/ruby-version-test
$ cd /tmp/ruby-version-test
$ rvm current
ruby-2.5.0
$ echo "2.6" > .ruby-version
$ cd ./
$ rvm current
ruby-2.6.1 I think note in this PR would help rvm and chruby users when migrating. |
My point is I'd rather not document this in the readme since it's not something that is explicit in the It may be helpful to let people coming from rvm know that they will they may have to change the format of their version strings. If you want to reword it so it's clear that the note only pertains to users coming from rvm I think that would be better. |
6a733b6
to
8238f88
Compare
8238f88
to
347d151
Compare
Fair enough, changed the wording to mention migrating from rvm/chruby. |
Thanks! Looks great! |
Related to asdf-vm/asdf#352.
This PR only documents current behaviour.