Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-cpython.sh: Don't repack the pip wheel #506

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

geofft
Copy link
Collaborator

@geofft geofft commented Jan 28, 2025

We're no longer patching it as of #401 (3dbca1c) so there's no longer a need to unpack and repack it.

We're no longer patching it as of astral-sh#401 (3dbca1c) so there's no longer
a need to unpack and repack it.
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Jan 28, 2025
@zanieb
Copy link
Member

zanieb commented Jan 28, 2025

Ideally we'd just test this on, e.g., platform:linux so we don't waste compute.

@geofft
Copy link
Collaborator Author

geofft commented Jan 28, 2025

Ah, whoops, how do I do that? I think I may I need access to set labels.

@zanieb zanieb merged commit 12d9c06 into astral-sh:main Jan 30, 2025
330 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants