Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[B028-doc-update] Update documentation for B028 #14338

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

njhearp
Copy link

@njhearp njhearp commented Nov 14, 2024

Summary

Resolves #14289
The documentation for B028 no_explicit_stacklevel is updated to be more clear.

Copy link
Contributor

github-actions bot commented Nov 14, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@njhearp njhearp changed the title [B028-doc-update] Update documentation for B028 (Fixes #14289) [B028-doc-update] Update documentation for B028 Nov 14, 2024
Copy link
Collaborator

@dylwil3 dylwil3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM! Thanks so much for your contribution!

/// It's recommended to use a `stacklevel` of 2 or higher, give the caller
/// more context about the warning.
/// It's recommended to use a `stacklevel` of 2 or higher, to give the caller
/// a more appropriate context about the warning.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think this line with just "more context about the warning" sounds better as is. (But the "give"--> "to give" looks good)

@MichaReiser MichaReiser added the documentation Improvements or additions to documentation label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(📚) documentation for B028 is misleading
3 participants