Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid fallback to PyPI in mixed CPU/CUDA example #11115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid fallback to PyPI in mixed CPU/CUDA example #11115

wants to merge 1 commit into from

Conversation

charliermarsh
Copy link
Member

Summary

This is roughly equivalent, but gets the non-+cpu macOS build from the PyTorch index rather than PyPI. It seems a bit simpler? Though up for debate.

@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Jan 30, 2025
@charliermarsh charliermarsh requested a review from zanieb January 30, 2025 19:00
@charliermarsh
Copy link
Member Author

Sort of torn on this. It does the same thing, but I don't know what's more intuitive.

zanieb
zanieb approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needing to explain a fallback for macOS makes sense to me. Should you use == darwin and == win32 instead of a negative marker again...?

@charliermarsh
Copy link
Member Author

Yeah... But that would probably end up with something in the lockfile like: sys_platform != 'win32' and sys_platform != 'darwin' and sys_platform != 'linux', for PyPI.

Base automatically changed from charlie/pt-2.6.0 to main January 30, 2025 19:05
@zanieb
Copy link
Member

zanieb commented Jan 30, 2025

But that would probably end up with something in the lockfile like: sys_platform != 'win32' and sys_platform != 'darwin' and sys_platform != 'linux', for PyPI.

That seems okay to me? Or at least seems explicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charliermarsh @zanieb