Improve performance of uv-python crate's manylinux submodule #11131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes a few performance improvements:
_GLibCVersion
tuple_is_compatible(arch, glibc_version)
tag
variable directly into the yield, reducing memory allocation in case this is never used when_is_compatible(arch, glibc_version)
is falseglibc_version
being in_LEGACY_MANYLINUX_MAP
and the assignment to the variable together. I'm not sure if this is actually better, but using the assignment expression reduces this from 4 lines to 2Test Plan
I upstreamed these changes in pypa/packaging#869. Otherwise, I'm pretty confident this is a minor change that works the same