chore: update 2024 finance info #3652
Conversation
derberg
requested review from
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe configuration files for financial expenses have been updated to reflect changes in amounts for existing categories and the addition of new entries for November and December 2024. The "Mentorship Program 2023" category has undergone specific adjustments in earlier months, while multiple new categories have been introduced for the last two months of the year. Additionally, several categories were removed from the Changes
Possibly related PRs
Suggested labels
Poem
Tip 🌐 Web search-backed reviews and chat
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 180000ms (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
no need to review yet, I'm still doing double review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3652 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 732 732
=========================================
Hits 732 732 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/finance/2024/Expenses.yml (1)
132-144: December Expense Entries Added Correctly with Minor Formatting IssueThe December section adds six expense entries, including the new event "AsyncAPI Conf on Tour 2024", which aligns well with the existing YAML structure. However, the static analysis tool flagged a missing newline character at the end of the file (line 144). Please ensure a newline is added at the end to conform with YAML best practices.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 144-144: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/finance/2024/Expenses.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
config/finance/2024/Expenses.yml
[error] 144-144: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 180000ms (4)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Lighthouse CI
🔇 Additional comments (1)
config/finance/2024/Expenses.yml (1)
123-131: November Expense Entries Added CorrectlyThe newly added November section includes entries for "Swag Store", "Community Manager", "Community Marketing Specialist", and "JSON Schema Sponsorship" with their respective amounts, and the YAML structure is consistent with the previous months. Please verify that these amounts and categories match the updated financial information for November 2024.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
config/finance/2024/ExpensesLink.yml (1)
31-33: Formatting Issues with "Community Marketing Specialist" Entry
The "Community Marketing Specialist" entry appears to have been reformatted rather than removed. However, YAMLlint reports two issues:
- Trailing spaces on the last line (line 33).
- Missing newline at the end of the file.
Please remove any trailing spaces and ensure that the file ends with a newline to conform with YAML standards.
Suggested diff:
- link: "https://github.com/orgs/asyncapi/discussions/1176" - + link: "https://github.com/orgs/asyncapi/discussions/1176"Ensure that the final file ends with a newline.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 33-33: no new line character at the end of file
(new-line-at-end-of-file)
[error] 33-33: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/finance/2024/Expenses.yml(3 hunks)config/finance/2024/ExpensesLink.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
config/finance/2024/ExpensesLink.yml
[error] 33-33: no new line character at the end of file
(new-line-at-end-of-file)
[error] 33-33: trailing spaces
(trailing-spaces)
config/finance/2024/Expenses.yml
[error] 145-145: no new line character at the end of file
(new-line-at-end-of-file)
[error] 145-145: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 180000ms (1)
- GitHub Check: Test NodeJS PR - macos-13
🔇 Additional comments (16)
config/finance/2024/ExpensesLink.yml (10)
1-3: Removal of "Ambassador Program" Category
The removal of the "Ambassador Program" entry is consistent with the updated 2024 financial information. Please make sure that any cross-references to this category in related files (for example, in Expenses.yml) have been updated accordingly.
4-6: Removal of "Google Season of Docs 2023" Category
The "Google Season of Docs 2023" entry has been removed as part of the update. Ensure that any dependent data in other finance files is in sync with this deletion.
7-9: Removal of "Swag Store" Category
The deletion of the "Swag Store" entry is straightforward. Confirm that any financial reporting or aggregations relying on it have been adjusted.
10-12: Removal of "Bounty Program" Category
The "Bounty Program" category removal appears intentional. Verify that its removal does not adversely affect linked financial summaries.
13-15: Removal of "3rd Party Services" Category
Removing the "3rd Party Services" category aligns with the update objective. Ensure that any historical data or related references are handled appropriately.
16-18: Removal of "Community Manager" Category
The deletion of the "Community Manager" entry is clear. Please double-check that the related financial documents no longer reference this category.
19-21: Removal of "AsyncAPI Conf on Tour 2023" Category
The "AsyncAPI Conf on Tour 2023" category has been removed. Verify that financial consolidations elsewhere reflect this change.
22-24: Removal of "AsyncAPI Conf on Tour 2024" Category
The removal of the "AsyncAPI Conf on Tour 2024" entry is noted. Ensure that any planning or reporting dependent on this data is updated.
25-27: Removal of "Mentorship Program 2023" Category
The deletion of the "Mentorship Program 2023" entry is in line with the overall updates. Please verify that its removal is correctly propagated to other financial summaries (e.g., in Expenses.yml).🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 27-27: trailing spaces
(trailing-spaces)
28-30: Removal of "JSON Schema Sponsorship" Category
The "JSON Schema Sponsorship" category has been removed appropriately. As with the other removals, cross-check any impacted references in related files.config/finance/2024/Expenses.yml (6)
23-24: Update Mentorship Program 2023 February Amount
The amount for the "Mentorship Program 2023" in February has been updated to '4125.00'. Please verify that this figure accurately reflects the intended 2024 financial update.
30-31: Adjust March Amount for Mentorship Program 2023
The March entry now shows an amount of '2475.00' for the "Mentorship Program 2023". Confirm that this decreased value correctly aligns with the revised financial data.
41-42: Update April Amount for Mentorship Program 2023
The April entry for "Mentorship Program 2023" is updated to '2475.00'. Please ensure this change is consistent with the updated financial information and overall year-long adjustments.
115-122: Review October Financial Entries
In October, the "AsyncAPI Conf on Tour 2024" amount has been modified from '962.01' to '289.78', and new entries for "Community Manager", "Community Marketing Specialist", and "JSON Schema Sponsorship" have been added. Verify that these adjustments are correct and consistent with the updated financial guidelines for 2024.
123-125: Add New November Entry for Swag Store
A new November entry for "Swag Store" with an amount of '472.36' has been added. Please confirm that this new entry, alongside the other November records, fully reflects the updated financial structure for the month.
132-145: 🛠️ Refactor suggestionIntroduce December 2024 Financial Entries & Address YAML Formatting
The December section introduces new financial entries with the following amounts:
- Bounty Program: '1400.00'
- Swag Store: '917.99'
- Community Manager: '2000.00'
- Community Marketing Specialist: '2000.00'
- JSON Schema Sponsorship: '250.00'
- AsyncAPI Conf on Tour 2024: '2767.99'
Please verify that these entries are correct per the updated financial information for December 2024.
Static Analysis Note: YAMLlint has flagged that line 145 has trailing spaces and is missing a newline at the end of the file. Ensuring that the file ends with a clean newline without trailing spaces will help maintain consistency and prevent linting errors.
A suggested diff for addressing the static analysis issues:
- Amount: '2767.99' - + Amount: '2767.99'and ensure that there is a newline at the end of the file.
✅ Verification successful
Error: No shell scripts or web queries found
Verification Successful: December 2024 Entries & YAML Formatting
The December section now accurately reflects the updated financial data. Please remove the trailing spaces on line 145 and ensure the file ends with a newline to resolve the YAMLlint issues.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 145-145: no new line character at the end of file
(new-line-at-end-of-file)
[error] 145-145: trailing spaces
(trailing-spaces)
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/finance/2024/ExpensesLink.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
config/finance/2024/ExpensesLink.yml
[error] 23-23: no new line character at the end of file
(new-line-at-end-of-file)
[error] 23-23: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 180000ms (1)
- GitHub Check: Test NodeJS PR - macos-13
🔇 Additional comments (1)
config/finance/2024/ExpensesLink.yml (1)
1-20: Streamline Outdated Expense CategoriesThe diff shows that several outdated categories (e.g., "Ambassador Program", "Google Season of Docs 2023", "Swag Store", etc.) have been removed. This cleanup appears to be in line with updating the financial information for 2024. Please ensure that these removals are coordinated with related configuration files (for instance, verifying that any necessary details now reside in the
Expenses.ymlfile) to avoid any discrepancies in category references or financial data.
config/finance/2024/ExpensesLink.yml
Outdated
| - category: "Community Marketing Specialist" | ||
| link: "https://github.com/orgs/asyncapi/discussions/1176" No newline at end of file | ||
| link: "https://github.com/orgs/asyncapi/discussions/1176" | ||
|
|
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Verify "Community Marketing Specialist" Entry and Fix Formatting
The AI summary indicates that the "Community Marketing Specialist" entry should remain unchanged, yet the diff suggests a deletion or modification of the entry (line 21 shows a removal marker and lines 22–23 show minor changes). Please confirm that this entry remains present as intended for accurate reporting. Additionally, YAMLlint flagged two formatting issues:
- Missing newline at end of file: Please ensure the file ends with a newline.
- Trailing spaces on the last line: Remove any extra whitespace.
A suggested diff for the formatting fixes:
-
\ No newline at end of file
+ **
Error: No shell scripts or web queries found
🏁 Script executed:
#!/bin/bash
FILE="config/finance/2024/ExpensesLink.yml"
echo "Checking file: $FILE"
if [[ ! -f $FILE ]]; then
echo "File $FILE does not exist."
exit 1
fi
echo "---- Excerpt (lines 21-23) ----"
sed -n '21,23p' "$FILE"
echo "---- Verifying 'Community Marketing Specialist' entry ----"
grep -n "Community Marketing Specialist" "$FILE" || echo "'Community Marketing Specialist' entry not found!"
echo "---- Checking for newline at the end of the file ----"
# Tail returns nothing if the file ends with a newline.
if [ -z "$(tail -c 1 "$FILE")" ]; then
echo "File ends with a newline."
else
echo "No newline at end of the file."
fi
echo "---- Checking for trailing whitespace ----"
grep -nE "[[:blank:]]+$" "$FILE" || echo "No trailing whitespace found."Length of output: 1120
Action: Fix YAML Formatting Issues in config/finance/2024/ExpensesLink.yml
- The "Community Marketing Specialist" entry is present and remains unchanged.
- The file is missing a newline at the end.
- There are trailing spaces at the end of the file (line 23).
Please update the file by removing the extra whitespace and ensuring it ends with a newline.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 23-23: no new line character at the end of file
(new-line-at-end-of-file)
[error] 23-23: trailing spaces
(trailing-spaces)
|
@akshatnema I'm too stupid for this yaml neat peak from rabbit. Adding new line, removing - always the same - can we ignore it 😄 or do you have a solution? |
|
/ptal |
|
@magicmatatjahu @devilkiller-ag @akshatnema @sambhavgupta0705 @anshgoyalevil @Mayaleeeee Please take a look at this PR. Thanks! 👋 |
update all 2024 finance info
Summary by CodeRabbit
New Features
Bug Fixes
Updates