Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed icon for gitfolders and git related files #208

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Aug 13, 2018

Description

Changes the git icon to a non-text version:
Before:
screenshot 2018-08-13 09 26 15
After:
screenshot 2018-08-13 09 30 51

The folder icon can be a bit difficult to read on low-res screens, but I prefer to have it in a folder shape compared to reusing the file icon.

  • Relevant Issues : change git icon #207
  • Relevant PRs : (none)
  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

@avdv
Copy link
Collaborator

avdv commented Aug 21, 2018

Thanks @mashehu, but I am a bit reluctant to change the icons since it's merely a matter of taste. Although you have a valid point that a folder's icon looks better as a folder, not just coloured like a folder.

You know that you can change the icons for yourself to your liking? See https://github.com/athityakumar/colorls#custom-configurations

As I said, I am not so sure right now, maybe when a few people show thumbs up for this change...

drn added a commit to drn/nerd-ls that referenced this pull request Sep 7, 2018
drn added a commit to drn/nerd-ls that referenced this pull request Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants