changed: Break non-async specific interrupt functionality out of async_hal module
#807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jbeaurivage
changed the title
async_hal moduleasync_hal module
sajattack
approved these changes
Jan 9, 2025
sajattack
force-pushed
the
non-async-interrupt
branch
from
381577f to
2ff56f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In preparation for #804, we realized that the
async_hal::interruptsmodule contained interrupt-related functionality that wasn't strictly specific to async operation. Break that out into its owninterruptmodule, so that it can be used even in non async contexts.Checklist