Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): Allow sorting filter modes #1717

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dasJ
Copy link

@dasJ dasJ commented Feb 13, 2024

Closes #1417
Closes #1654
cc @hco

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@dasJ dasJ force-pushed the feat/configurable-filter-modes branch from da8cf55 to 8fb964c Compare February 14, 2024 09:22
@ellie
Copy link
Member

ellie commented Feb 15, 2024

Thank you for the work here! This seems very similar to #1655 :/

Just waiting on @matthiasbeyer in that one (I've been a little slow to review), but I'd rather stick with that PR as it came in much sooner.

@dasJ
Copy link
Author

dasJ commented Feb 15, 2024

Looks like I didn't see that one :/ But yes, I agree that the sooner PR is probably to be preferred. I will keep this one open for now for reference but will close when the other one is accepted :)

@ellie
Copy link
Member

ellie commented Feb 15, 2024

Thank you!

@dasJ
Copy link
Author

dasJ commented Mar 30, 2024

@ellie Since the PR seems to be stalled, would it be a possibility to consider this one again? Another reason would be that this one fixes #1654

@matthiasbeyer
Copy link
Contributor

Ah, yes sorry that I have not got around to continue my PR. 😞 Feel free to take my patches or close it unmerged, as long as we're getting the feature 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Allow changing order of filter modes
3 participants