Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zsh_histdb import issue #2350

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tru2dagame
Copy link

Fix Import Error by Modifying Order Clause

This PR addresses an import zsh-hist-db error by changing the order clause in the query.
The current implementation uses ORDER BY history.start_time, which is causing issues. The fix involves using ORDER BY history.id instead. The order by id and start_time produces the same sequence, and since id is the primary key, this change may improve the query performance.

Screenshots

Error Screenshot:
image
Histdb Query Testing:
image image

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant