-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to JDK 17 and JakartaEE 6.0 #138
base: master
Are you sure you want to change the base?
Conversation
Further Context : Upgraded only to jdk17 instead of 21 because the oss-plugin didnt run with jdk 21 - and gradle support for jdk 21 is fairly new. |
👋 hey @TareqK, thanks for the PR! This is something that we plan to do in a new major version. We may revisit this PR when work on that release begins, but it's not something we can accept right now as it would be a breaking change that would require a new major version release. |
hi @jimmyjames any estimate (months or years) of when the next major version is planned for would be helpful. If it is not planned for the near future, was thinking of maintaining a fork until the fix is released, since it is blocking moving to spring boot 3 |
Hi @TareqK, Thank you for the PR Can you please sign your commits without which I won't be able to add your commits. |
Hi! Let me actually do some fixed because I see there are conflicts first and I'll get it handled over the weekend hopefully |
Changes
This is a refactor that upgrades the mvc-common library to Jakarta EE6.0 and JDK 17, allowing use on more modern servers and libraries - the tests were also fixed to account for the expiration of tokens. The main changes were to the build and namespaces of imports - with some changes to the tests using regexes.
References
solves #111
Testing
Checklist
Added Context
This will break the current API as it changes all the required args to another package. Will fail CI check for API Changes - but this is expected and part of the issue.