-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(autoware_vehicle_info_utils): move package to common directory #8708
chore(autoware_vehicle_info_utils): move package to common directory #8708
Conversation
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
@mitsudome-r https://github.com/autowarefoundation/autoware.universe/blob/main/.github/CODEOWNERS |
@mitsudome-r |
@tkimura4 Thanks. I think the codeowner should be updated automatically by this workflow: https://github.com/autowarefoundation/autoware.universe/blob/main/.github/workflows/update-codeowners-from-packages.yaml |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8708 +/- ##
==========================================
+ Coverage 24.11% 24.15% +0.03%
==========================================
Files 1400 1402 +2
Lines 102280 102347 +67
Branches 38765 38794 +29
==========================================
+ Hits 24668 24719 +51
- Misses 75014 75029 +15
- Partials 2598 2599 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for the suggestion. I have never used it before. I can take a look, but is the tool able to retain the git history without making a force-push to the main branch? I rather not do disturbing changes to the commit history of the main branch. Also FYI, you should still able to track the history by adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mitsudome-r
lgtm for me
@mitsudome-r Could you merge this? |
Description
This moves autoware_vehicle_info_utils into common directory since the package is used by the packages in different modules (planning, control, system, common, etc)
Related links
Parent Issue:
common
packages are not functioning as a true "common" #8695How was this PR tested?
Notes for reviewers
This PR does not change anything in the code and shouldn't have any affect on Autoware's behavior.
Interface changes
None.
Effects on system behavior
None.