Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoware_vehicle_info_utils): move package to common directory #8708

Merged

Conversation

mitsudome-r
Copy link
Member

Description

This moves autoware_vehicle_info_utils into common directory since the package is used by the packages in different modules (planning, control, system, common, etc)

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

This PR does not change anything in the code and shouldn't have any affect on Autoware's behavior.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Sep 2, 2024
Copy link

github-actions bot commented Sep 2, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 2, 2024
@tkimura4
Copy link
Contributor

tkimura4 commented Sep 2, 2024

@mitsudome-r
I think the following files might also need to be changed.

https://github.com/autowarefoundation/autoware.universe/blob/main/.github/CODEOWNERS

@taikitanaka3
Copy link
Contributor

@mitsudome-r
I think git log was deleted by this PR.
so I think it's better to use git filter repo instead

@mitsudome-r
Copy link
Member Author

@tkimura4 Thanks. I think the codeowner should be updated automatically by this workflow: https://github.com/autowarefoundation/autoware.universe/blob/main/.github/workflows/update-codeowners-from-packages.yaml

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.15%. Comparing base (d92b054) to head (b104036).
Report is 160 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8708      +/-   ##
==========================================
+ Coverage   24.11%   24.15%   +0.03%     
==========================================
  Files        1400     1402       +2     
  Lines      102280   102347      +67     
  Branches    38765    38794      +29     
==========================================
+ Hits        24668    24719      +51     
- Misses      75014    75029      +15     
- Partials     2598     2599       +1     
Flag Coverage Δ *Carryforward flag
differential 28.28% <ø> (?)
total 24.11% <ø> (ø) Carriedforward from d92b054

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r
Copy link
Member Author

@taikitanaka3

I think git log was deleted by this PR.
so I think it's better to use git filter repo instead

Thanks for the suggestion. I have never used it before. I can take a look, but is the tool able to retain the git history without making a force-push to the main branch? I rather not do disturbing changes to the commit history of the main branch.

Also FYI, you should still able to track the history by adding --follow option. (e.g., git log --follow common/autoware_vehicle_info_utils/src/vehicle_info_utils.cpp) You can also check through GitHub UI by clicking "Browse History" in commit history page, although this only works with a file and not with a directory.
image

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mitsudome-r
lgtm for me

@youtalk
Copy link
Member

youtalk commented Sep 12, 2024

@mitsudome-r Could you merge this?

@mitsudome-r mitsudome-r merged commit 90347e3 into autowarefoundation:main Sep 17, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants