Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): separation from universe-devel stage to universe-planning-control-devel stage #5194

Merged
merged 15 commits into from
Sep 9, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Sep 7, 2024

Description

Resolved #5081

This PR separates from universe-devel stage to universe-planning-control-devel stage as well as universe-sensing-perception-devel and universe-localization-mapping.

I left TODO comments regarding autowarefoundation/autoware.universe#8805.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Base automatically changed from upstream-universe-localization-mapping to main September 9, 2024 09:10
@youtalk
Copy link
Member Author

youtalk commented Sep 9, 2024

@oguzkaganozt Please review this too.

Copy link
Contributor

@oguzkaganozt oguzkaganozt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but if we can resolve this autowarefoundation/autoware.universe#8805 it would be even better. Thanks @youtalk-san as always.

@youtalk youtalk merged commit de26d57 into main Sep 9, 2024
15 checks passed
@youtalk youtalk deleted the upstream-universe-planning-control-devel branch September 9, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Split the planning/control packages into a separate container
2 participants