-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): add simulator-visualizer container #5411
base: main
Are you sure you want to change the base?
Conversation
c0afed8
to
637d735
Compare
637d735
to
f7337c8
Compare
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry for the delayed review.
docker/tools/Dockerfile
Outdated
|
||
# Set up VNC password | ||
RUN mkdir -p ~/.vnc && \ | ||
echo "openadkit" | vncpasswd -f > ~/.vnc/passwd && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don’t want to write the password directly in the Dockerfile
. We want to pass it through an environment variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will make it work without a password because the tools would be for generic usage.
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
79d8a6f
to
4b9b35b
Compare
Signed-off-by: Oguz Ozturk <[email protected]>
# # Set up VNC password | ||
# RUN mkdir -p ~/.vnc && \ | ||
# echo "openadkit" | vncpasswd -f > ~/.vnc/passwd && \ | ||
# chmod 600 ~/.vnc/passwd | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete them if you don't need. You can revert them from this PR when you will need.
Please fix the https://results.pre-commit.ci/run/github/41331761/1737026915.ReZe0rS_QaW-5f0MZ2o0mA error too. |
Description
To enable full development and deployment with containers, a dedicated simulator-visualizer container will be beneficial. This container will include the Tier IV Scenario Simulator, RViz Plugins, all necessary ROS 2 message definitions.
Additionally, it will support VNC and NoVNC so users can visualize the RViz screen remotely.
Tests performed
https://github.com/autowarefoundation/autoware/actions/runs/12582124201
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.