Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeStar Source for build pipeline generation (support for bitbucket source) #1891

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

robincsamuel
Copy link

@robincsamuel robincsamuel commented Feb 16, 2022

#1038

Updated the cli method generate-pipeline to support codestar connection for bitbucket.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Reference: https://docs.aws.amazon.com/codepipeline/latest/userguide/action-reference-CodestarConnectionSource.html

@robincsamuel robincsamuel changed the title CodeStar source for build pipeline generation CodeStar Source for build pipeline generation (support for bitbucket source) Feb 16, 2022
Copy link
Member

@jamesls jamesls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, changes look good to me. We just need to get the CI passing, looks like there's a few type hints that need to be added.

@robincsamuel
Copy link
Author

@jamesls I've updated the typings, could you please run the workflow again?

@robincsamuel
Copy link
Author

@jamesls gentle reminder :)

@charlesreid1
Copy link

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants