Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct key for cognito username #1892

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kapilt
Copy link
Contributor

@kapilt kapilt commented Feb 19, 2022

Description of changes:

local cognito auth is broken, due to using an incorrect claim key for username, its not clear where the previous value comes from all cognito jwt payload docs point to username.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jamesls
Copy link
Member

jamesls commented Mar 15, 2022

I think this might be the difference between the ID token, which appears to use the cognito:username key (https://docs.aws.amazon.com/cognito/latest/developerguide/amazon-cognito-user-pools-using-the-id-token.html) vs. the access token, which uses username (https://docs.aws.amazon.com/cognito/latest/developerguide/amazon-cognito-user-pools-using-the-access-token.html).

Maybe we can just check for both, but I think we still need to support cognito:username.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants