test to [[ where available
#261
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: - init.sh: fix a missing `-d` - github-download: fix a missing `-n` - mount-helper: fix a missing `-n` - setup-git: fix a missing `test`/`[[` - waiter: fix missing `-n` todos: - note this change of convention in the docs - see if there is an alternative for the sudo calls - review the PR to check if there were any errors
- add `is-(directory|file|missing|not-directory|present|readable)(.bash)?` - is-missing: fix incorrect help text on exit status
- mount-helper: fix missing `-n`, however seems better to just always fetch a single line here - debug-network: fix WIP commit using `[[` in a sh script, instead of `[`
- `while true` to `while :`, and `true` to `:` where appropriate - brew: compact a conditional - (choose|config-helper|confirm|echo-lines|is-empty-value|setup-(git|linux|mac|system)): compact an or conditional - is-suffix: update for `__substr` shim in `bash.bash` for bash v3 support - `is-dir`: move to deprecated, as there is now `is-directory`
balupton
commented
Oct 29, 2024
| bg="${bg##*;}" # trim everything prior to the last ; | ||
| if test "$bg" = 'default' || test "$bg" -le 6 -o "$bg" -eq 8; then | ||
| if [[ $bg == 'default' ]] || (is-digit -- "$bg" && [[ $bg -le 6 || $bg -eq 8 ]]); then |
There was a problem hiding this comment.
the introduction of is-digit here is a sanity check to prevent weird behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This convention change improves performance and resolves edge cases when
test -n "$a" -a "$b" = "$c"wherea=>.fixes:
-d-n-n, one of them seems better to not exist (as we should always just want the first line in that case)test/[[-nother changes:
is-(directory|file|missing|not-directory|present|readable)(.bash)?, such that sudo doesn't have to call problematictestcommandtodos: