Possible fix for AutoGroupService and SM Dispell #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…race to the same instance (can only happen the same race on pvp instance Harmony, Discipline, Glory and Chaos ?)
…ved in case the target dont have more buffs to be dispelled.
jvbhidalgo
commented
Jan 29, 2025
| @@ -53,6 +56,10 @@ public void startLooking(Player player, int maskId, EntryRequestType ert) { | |||
| PacketSendUtility.broadcastToWorld( | |||
| new SM_MESSAGE(0, null, player.getRace().getL10n() + " have registered for " + agt.getL10n() + ".", ChatType.BRIGHT_YELLOW_CENTER), | |||
| p -> p.getRace() != player.getRace() && agt.isInLvlRange(p.getLevel())); | |||
| }else if( AutoGroupConfig.ANNOUNCE_BATTLEGROUND_REGISTRATIONS && (agt.isHarmonyArena() || agt.isPvPSoloArena()) ){ | |||
There was a problem hiding this comment.
this can be disregarded, was created to announce applies on Harmony and Discipline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem that when 2 groups of the same race applyed at Idgel Dome (exemple), it was poping the Enter for them, and when entering, they were at the same side, like a group of 12, or sometimes 8 in one instance and 4 on another instance.
The fix ive made, now its validating Arenas and PVP DG, if allow same race, the amount of players need to pop enter.
1 possible problem: After the changes, on Harmony happened to send 1 player of the group (3 members group) to a instance alone, while the rest of the group went to the correct instance against the other group.
Tested on Terath Dredg, Idgel Dome, Kamar, Discipline, Harmony.
SM Dispell:
https://aioncodex.com/5x/skill/3574/?sl=1
This skill, Infernal Pain and Magic Implosion, have a tag (can be dispelled), what it means? if the SM dispell a taget, and the target had only 2 buffs (the magic implosion remove 3 buffs), if the target had only 2 buffs and a debuff like Infernal Pain. The result would be the 2 buffs removed and the Infernal Pain removed. If was 2 buffs and Erosion, the Erosion cannot be removed. and the result would be only 2 buffs of the target removed.
Today its removing even Erosion, so i made a validation to check the STACK/GROUP of only these skills (Infernal Pain, Shackle of Vulnerability and Magic Implosion).