target can be null

bigskysoftware · Aug 1, 2024 · 8817374 · 8817374
1 parent f010924
commit 8817374
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/htmx.js b/src/htmx.js
@@ -2313,7 +2313,7 @@ var htmx = (function() {
       return false
     }
     if (evt.type === 'submit' || evt.type === 'click') {
-      if (elt.tagName === 'FORM' && asElement(evt.target).tagName === 'FORM') {
+      if (elt.tagName === 'FORM' && asElement(evt.target)?.tagName === 'FORM') {
         return true
       }
       if (matches(elt, 'input[type="submit"], button') && closest(elt, 'form') !== null) {

diff --git a/test/core/internals.js b/test/core/internals.js
@@ -98,6 +98,9 @@ describe('Core htmx internals Tests', function() {
 
     htmx._('shouldCancel')({ type: 'click', target: document.createElement('form') }, form).should.equal(true)
 
+    // function works also when target isn't an Element
+    htmx._('shouldCancel')({ type: 'click', target: null }, form).should.equal(false)
+
     var form = make("<form><input id='i1' type='submit'></form>")
     var input = byId('i1')
     htmx._('shouldCancel')({ type: 'click', target: document.createElement('input') }, input).should.equal(true)