Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-15445] Update marketing route for organizations when in cloud #13123

Merged

Conversation

amorask-bitwarden
Copy link
Contributor

@amorask-bitwarden amorask-bitwarden commented Jan 29, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-15445

📔 Objective

Updates the product-switcher.service to check if the application is running in Self-Host. If it's not, it changes the marketingRoute when the user has no organization to be "/create-organization".

📸 Screenshots

Screen.Recording.2025-01-29.at.9.11.23.AM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Logo
Checkmarx One – Scan Summary & Detailsbbaca0f3-222b-47b7-a6c5-945253415af9

New Issues (2)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /bitwarden_license/bit-web/src/app/tools/access-intelligence/critical-applications.component.html: 87
detailsMethod critical_applications_component at line 87 of /bitwarden_license/bit-web/src/app/tools/access-intelligence/critical-applications.component.h...
Attack Vector
MEDIUM Client_Privacy_Violation /bitwarden_license/bit-web/src/app/tools/access-intelligence/critical-applications.component.html: 82
detailsMethod critical_applications_component at line 82 of /bitwarden_license/bit-web/src/app/tools/access-intelligence/critical-applications.component.h...
Attack Vector

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.48%. Comparing base (ea41b1a) to head (a54f300).
Report is 69 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13123   +/-   ##
=======================================
  Coverage   35.48%   35.48%           
=======================================
  Files        3007     3007           
  Lines       90868    90871    +3     
  Branches    16904    16906    +2     
=======================================
+ Hits        32247    32249    +2     
  Misses      56119    56119           
- Partials     2502     2503    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vleague2 vleague2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the lint errors will be fixed if you pull in latest main!

@vleague2 vleague2 removed the request for review from merissaacosta January 29, 2025 19:56
@amorask-bitwarden amorask-bitwarden merged commit 6a94b4d into main Feb 6, 2025
36 of 38 checks passed
@amorask-bitwarden amorask-bitwarden deleted the billing/PM-15445/update-link-product-switcher branch February 6, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants