Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13026] Refactor remove and bulkremove methods to throw error if user is managed by an organization #5034

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Nov 13, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13026

📔 Objective

Verified members should not be removed. Instead, verified members should go through the deletion flow to ensure all their individual data is properly deleted. This change will prevent accidental removals and enforce consistent deletion practices for verified members.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.70%. Comparing base (702a81b) to head (b711506).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...Console/Controllers/OrganizationUsersController.cs 0.00% 1 Missing ⚠️
...OrganizationUsers/RemoveOrganizationUserCommand.cs 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5034      +/-   ##
==========================================
+ Coverage   42.58%   42.70%   +0.11%     
==========================================
  Files        1406     1406              
  Lines       65074    65114      +40     
  Branches     5962     5974      +12     
==========================================
+ Hits        27715    27806      +91     
+ Misses      36131    36064      -67     
- Partials     1228     1244      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 13, 2024

Logo
Checkmarx One – Scan Summary & Details7e4823ad-2cf2-45b9-93a6-84996e437870

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/AdminConsole/Controllers/GroupsController.cs: 92 Attack Vector
LOW Heap_Inspection /src/Core/Constants.cs: 129 Attack Vector
LOW Use_Of_Hardcoded_Password /src/Core/Constants.cs: 129 Attack Vector

@r-tome r-tome marked this pull request as ready for review November 14, 2024 12:42
@r-tome r-tome requested a review from a team as a code owner November 14, 2024 12:42
@r-tome r-tome requested a review from eliykat November 14, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant