Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display file roles on show -f #760

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

n2taylor
Copy link

This is an implementation of the Enhancement in #419. My very first Clojure PR!

Description

This change modifies the print-fileset helper to include file roles in the displayed output. The file roles were derived from the fileset directly. If there is a better way to access the file roles, please advise.

Motivation and Context

It's for Issue #419

How Has This Been Tested?

Tested against various Boot projects out in the wild with no issues. Also I cobbled together a toy repo to test against locally (this is not included in the PR). Otherwise there are no automated test changes here.

It has only been tested on Mac OS X.

Screenshots (if appropriate):

Before:
Screen Shot 2020-01-16 at 1 49 19 PM

After:
Screen Shot 2020-01-16 at 1 21 14 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant