-
Notifications
You must be signed in to change notification settings - Fork 315
Implemented FlySystem for FileSystem abstraction #46
base: master
Are you sure you want to change the base?
Conversation
Thanks for this, shall take a look at it today. |
Sorry, been very busy. @codeguy can you take a look at this too? |
I am happy with this as a first step i think. |
Thoughts? |
I like. @scottrobertson what else do you have in mind? |
We should pick this up again, sorry i did not respond. Is this still ok to merge? |
Coming to this late but one thing to watch out for here is that FlySystem requires PHP 5.4+, while this library is currently baselined at 5.3. |
@bradleyboy Good point. I'm fine bumping the requirements. I'll do that shortly. |
@codeguy any update on this? |
@codeguy Not to be annoying, but I'm really interested in using this with Flysystem, so I'm just wondering if you plan on merging this? Thanks 😄 |
Any update on this PR? |
👍 any ETA when this could possibly be implemented? |
Bump. |
Any update on this? |
Hellooooooo.... Is this repo still active? |
Will this be merged |
Solves #41
I wasn't exactly sure if this is the best method or not, but it works. Basically I took out the FileStorage interface and replaced it with FlySystem.