Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AN-333] Prevent infinite DRS download retries #7679

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

[AN-333] Prevent infinite DRS download retries #7679

wants to merge 3 commits into from

Conversation

lucymcnatt
Copy link
Contributor

Description

Release Notes Confirmation

CHANGELOG.md

  • I updated CHANGELOG.md in this PR
  • I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

  • I added a suggested release notes entry in this Jira ticket
  • I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

LizBaldo
LizBaldo approved these changes Jan 17, 2025
View reviewed changes
Copy link

@LizBaldo LizBaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the change makes sense. You mentioned that the tricky part was around testing. Did you meant manual testing, or adding a new unit test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LizBaldo LizBaldo LizBaldo approved these changes

@jgainerdewar jgainerdewar Awaiting requested review from jgainerdewar

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucymcnatt @LizBaldo