Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to ignore illegal headers #973

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

added option to ignore illegal headers #973

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4eb16df
added option to ignore illegal headers
jyang-broad Jan 31, 2023
5a590d3
debug - remove liveness startup
jyang-broad Jan 31, 2023
60b5c3b
try remove auto-array
jyang-broad Jan 31, 2023
f83084b
reinstate livenessServerStartup
jyang-broad Feb 1, 2023
ffcbf50
added comments
jyang-broad Feb 2, 2023
e23d80a
empty commit retry CI
jyang-broad Mar 22, 2023
892da32
Merge remote-tracking branch 'origin/develop' into DDO-2622-ignore-ba…
jyang-broad Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/main/resources/sam.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ akka {
server {
idle-timeout = 180 s
request-timeout = 60 s
parsing {
# Supresses akka http header warnings such as Illegal header: Illegal 'x-forwarded-host'
# These warnings can sometimes come from apache and akka disagreeing on web standards
# Takes an array that can be set with seperate env vars in the format: IGNORE_ILLEGAL_HEADERS.0, IGNORE_ILLEGAL_HEADERS.1, etc.
ignore-illegal-header-for = ${?IGNORE_ILLEGAL_HEADERS}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind adding a comment explaining what this is and why it might be used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gladly! hows that?

}
}
host-connection-pool {
max-open-requests = 16384
Expand Down