Use sane ready event. Fixes #21 #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,6 +39,22 @@ describe('broccoli-sane-watcher', function (done) { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should pass watchman option to sane', function () { | |||
| fs.mkdirSync('tests/fixtures/a'); | |||
There was a problem hiding this comment.
this should likely guard if watchman isn't installed. That being said, for nix environments like travis we should also likely install it it.
|
i'll try this out in the context of a ember-cli app this weekend, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sane uses the clock command to initiate watchman and emit the
readyevent when it's ready to be used. This PR gets broccoli-sane-watcher to use the ready event.