Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tarball generation error message #1169

Open
wants to merge 1 commit into
base: 3.4
Choose a base branch
from
Open

Add tarball generation error message #1169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/shared_config_manager/services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import logging
import os.path
import re
import subprocess
import shlex
import subprocess # nosec
from collections.abc import Iterable
from typing import Any, Optional, Union, cast

Expand Down Expand Up @@ -192,4 +193,8 @@ def _proc_iter(proc: subprocess.Popen[bytes]) -> Iterable[Union[bytes, Any]]:
break
yield block
if proc.wait() != 0:
_LOG.error(
"Error building the tarball with '%s'",
shlex.join(proc.args), # type: ignore[arg-type]
)
raise HTTPServerError("Error building the tarball")
Loading