Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loosened metadata checks #93

Merged
merged 2 commits into from
Jan 9, 2024
Merged

loosened metadata checks #93

merged 2 commits into from
Jan 9, 2024

Conversation

PietroPasotti
Copy link
Collaborator

@PietroPasotti PietroPasotti commented Jan 9, 2024 •
edited
Loading

Fixes #92

Issue:

  • the presence of a charmcraft.yaml file confused the code used to determine what version of charmcraft was used to init the charm repo.

Solution:

  • make the checks more accurate

@PietroPasotti PietroPasotti merged commit 22d48dc into main Jan 9, 2024
2 checks passed
@PietroPasotti PietroPasotti deleted the fix-metadata-autoload branch January 9, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyandrewmeyer tonyandrewmeyer tonyandrewmeyer approved these changes

@sed-i sed-i Awaiting requested review from sed-i

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression between v5.4 and v5.8: ValueError: invalid metadata: mandatory "name" field is missing
2 participants
@PietroPasotti @tonyandrewmeyer