Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added inverse transform #7999

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Added inverse transform #7999

merged 1 commit into from
Jul 31, 2024

Conversation

glopezdiest
Copy link
Contributor

@glopezdiest glopezdiest commented Jul 31, 2024 •
edited by Blyron
Loading

Description

Exposed the C++ InverseTransformPoint() into the API. Docs are missing

Where has this been tested?

  • Platform(s): Ubuntu 20.04
  • Python version(s): 3.8
  • Unreal Engine version(s): CARLA

Possible Drawbacks

None

This change is Reviewable

@glopezdiest glopezdiest requested a review from a team as a code owner July 31, 2024 08:37
@update-docs Update Docs
Copy link

update-docs bot commented Jul 31, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes.

@Blyron Blyron merged commit eeb507e into dev Jul 31, 2024
Daraan added a commit to Daraan/CARLA-Simulator-Fork-DebianFix that referenced this pull request Aug 1, 2024
@Daraan
Added inverse_transform and fixes for Transform
3fd09a9 
inverse_transform from carla-simulator#7999
highlighted in-place character
Daraan added a commit to Daraan/CARLA-Simulator-Fork-DebianFix that referenced this pull request Aug 1, 2024
@Daraan
Added inverse_transform and fixes for Transform
5377399 
inverse_transform from carla-simulator#7999
highlighted in-place character
@Daraan Daraan mentioned this pull request Aug 1, 2024
Open
1 task
@Daraan
Copy link

Daraan commented Aug 1, 2024

Added docs in #7982

    - def_name: inverse_transform
      params:
      - param_name: in_point
        type: carla.Vector3D
        doc: >
          Location in the space to which the inverse transformation will be applied.
      doc: >
        Applies the inverse of `transform` by translating a 3D point in place from global to local coordinates using the current transformation as frame of reference.

Maybe you can comment whether you think its fitting.

Daraan added a commit to Daraan/CARLA-Simulator-Fork-DebianFix that referenced this pull request Aug 8, 2024
@Daraan
Added inverse_transform and fixes for Transform
c2db0d1 
inverse_transform from carla-simulator#7999
highlighted in-place character
Daraan added a commit to Daraan/CARLA-Simulator-Fork-DebianFix that referenced this pull request Aug 8, 2024
@Daraan
Added inverse_transform and fixes for Transform
f0a427f 
inverse_transform from carla-simulator#7999
highlighted in-place character
Daraan added a commit to Daraan/CARLA-Simulator-Fork-DebianFix that referenced this pull request Sep 6, 2024
@Daraan
Added inverse_transform and fixes for Transform
f4c94e8 
inverse_transform from carla-simulator#7999
highlighted in-place character
Daraan added a commit to Daraan/CARLA-Simulator-Fork-DebianFix that referenced this pull request Sep 17, 2024
@Daraan
Added inverse_transform and fixes for Transform
44e4ff3 
inverse_transform from carla-simulator#7999
highlighted in-place character
Daraan added a commit to Daraan/CARLA-Simulator-Fork-DebianFix that referenced this pull request Sep 23, 2024
@Daraan
Added inverse_transform and fixes for Transform
cdb2664 
inverse_transform from carla-simulator#7999
highlighted in-place character
Blyron added a commit that referenced this pull request Sep 25, 2024
@Blyron @MattRoweEAIF
@glopezdiest @Minokori @Daraan @AreopagX @jorge-kabuto @sergiopaniego @Ylmdrin
Dev (#8185)
43441c7 
* added cpp client build docs (#7942)

* fixed IMU units (#7960)

* Update README.md with new TinyURL links (#7988)

* Added inverse transform (#7999)

Co-authored-by: glopezdiest <[email protected]>

* Aaron/fixwheelchair (#8001)

* Fix OSM2ODR build

* Updated fix wheelchair default value

* Docs/unit updates (#8007)

* fixed IMU units

* updated autitwheel version

* Add a `*.pyi` file for auto-completion & hints.

To enable auto-completion and hints in code editors such as VScode, create a `*.pyi` file. This feature is compatible with `python 3.9` and later versions.

* Fixes and missing Iterators

* Fixed Actor.parent

Can be None or an Actor

* Fixed missing return types

* Updated changelog

needs merge with dev version

* Added DSVEventArray iterator

* Added missing type for Labelled Point

* Fixed spelling misstakes

* Removed wrong unit indication

* Added missing -> World to load_world

* Added missing return value to reload_world

* FIX: __init__ methods do not return

* FIX: added ApplyTransform, fixed ApplyTorque

* Filled in missing information and types.

* ActorList.filter actually returns ActorList

* Fixed CityObjectLabels

* Disambiguated get_waypoint signature

Syntax fix (squased)

* Added undocumented variables

FutureActor
laod_world_if_different

* Corrected Sensor.is_listening

Was changed to a function in 0.9.15. More info see: #7439

* Added type hints for `values` attribute on enums

* Fix intendation shadowing methods

* Fix missing @Property

* Formatted some docstring to be shorter

* Added stubs for HUD drawing

Functions from #7168

* Corrected and more precise type-hints

- fixed carla.Waypoint.next_until_lane_end

* Improved get_waypoint disambiguation

correctly added two overload function

* Fix spelling mistakes

* Better usage of Enum if typing.Self is availiable

Using Self will not report an override / incompatible error.

* Fix: Enum values were tuples. Added Flag or Int to Enums

* Fixes for wrong stubs

- OpendriveGenerationParameter had no init
- missing @Property
- wrong signatures

* Added self parameter to property signatures

* Various fixes

- wrong signatures
- wrong names

* Added setters for VehicleControl

* Improved get_waypoints and Literal type hints

* Corrected [try_]spawn_actor keyword name

* Added Transform.inverse_transform and corrected signature

parameter is called in_point not in_vector

* Improved Callable and callbacks signature

* Corrections and additions

more setters
missing, wrong types corrected
spelling

* Fixed Vector arithmetic

* added digital twins video (#8090)

* navigation information is now loaded when changing maps

* Porting the changes done to UE5 to fix the recording leak to UE4

The slowdown is considerably more noticeable here since the engine runs much smoother. This makes evident that this is a stopgap measure, and should be looked into further down the line.

* Fixed typo in CityScapes palette (#8137)

* Correcting makefile typo to avoid override warning for target "downloadplugins" (#8167)

The downloadplugins target is already defined below (line 162).

---------

Co-authored-by: MattRoweEAIF <[email protected]>
Co-authored-by: glopezdiest <[email protected]>
Co-authored-by: glopezdiest <[email protected]>
Co-authored-by: Minokori <[email protected]>
Co-authored-by: Daniel <[email protected]>
Co-authored-by: AreopagX <[email protected]>
Co-authored-by: Jorge Virgos <[email protected]>
Co-authored-by: Sergio Paniego Blanco <[email protected]>
Co-authored-by: Ylmdrin <[email protected]>
Blyron added a commit that referenced this pull request Oct 18, 2024
@Daraan @MattRoweEAIF
@Blyron @glopezdiest @Minokori @AreopagX @jorge-kabuto @sergiopaniego @Ylmdrin
Typing and modernisation of Agent code (#8072)
9a59963 
* added cpp client build docs (#7942)

* fixed IMU units (#7960)

* Update README.md with new TinyURL links (#7988)

* Added inverse transform (#7999)

Co-authored-by: glopezdiest <[email protected]>

* Aaron/fixwheelchair (#8001)

* Fix OSM2ODR build

* Updated fix wheelchair default value

* Docs/unit updates (#8007)

* fixed IMU units

* updated autitwheel version

* Add a `*.pyi` file for auto-completion & hints.

To enable auto-completion and hints in code editors such as VScode, create a `*.pyi` file. This feature is compatible with `python 3.9` and later versions.

* Fixes and missing Iterators

* Fixed Actor.parent

Can be None or an Actor

* Fixed missing return types

* Updated changelog

needs merge with dev version

* Added DSVEventArray iterator

* Added missing type for Labelled Point

* Fixed spelling misstakes

* Removed wrong unit indication

* Added missing -> World to load_world

* Added missing return value to reload_world

* FIX: __init__ methods do not return

* FIX: added ApplyTransform, fixed ApplyTorque

* Filled in missing information and types.

* ActorList.filter actually returns ActorList

* Fixed CityObjectLabels

* Disambiguated get_waypoint signature

Syntax fix (squased)

* Added undocumented variables

FutureActor
laod_world_if_different

* Corrected Sensor.is_listening

Was changed to a function in 0.9.15. More info see: #7439

* Added type hints for `values` attribute on enums

* Fix intendation shadowing methods

* Fix missing @Property

* Formatted some docstring to be shorter

* Added stubs for HUD drawing

Functions from #7168

* Corrected and more precise type-hints

- fixed carla.Waypoint.next_until_lane_end

* Improved get_waypoint disambiguation

correctly added two overload function

* Fix spelling mistakes

* Better usage of Enum if typing.Self is availiable

Using Self will not report an override / incompatible error.

* Fix: Enum values were tuples. Added Flag or Int to Enums

* Fixes for wrong stubs

- OpendriveGenerationParameter had no init
- missing @Property
- wrong signatures

* Added self parameter to property signatures

* Various fixes

- wrong signatures
- wrong names

* Added setters for VehicleControl

* Improved get_waypoints and Literal type hints

* Corrected [try_]spawn_actor keyword name

* Added Transform.inverse_transform and corrected signature

parameter is called in_point not in_vector

* Improved Callable and callbacks signature

* Corrections and additions

more setters
missing, wrong types corrected
spelling

* Fixed Vector arithmetic

* added digital twins video (#8090)

* Typing for GlobalRoutePlanner

* 0.9.13+ modernisation of code

* made function static

* Updated changelog

* fixed spelling mistakes

* No unnecessary inheritance from object and empty class brackets & other

Removed empty variables and whitespaces
formatting

* navigation information is now loaded when changing maps

* Porting the changes done to UE5 to fix the recording leak to UE4

The slowdown is considerably more noticeable here since the engine runs much smoother. This makes evident that this is a stopgap measure, and should be looked into further down the line.

* Fixed typo in CityScapes palette (#8137)

* Correcting makefile typo to avoid override warning for target "downloadplugins" (#8167)

The downloadplugins target is already defined below (line 162).

* fix typo in title (#8225)

* added unreal coord system, fixed v2x (#8251)

---------

Co-authored-by: MattRoweEAIF <[email protected]>
Co-authored-by: Blyron <[email protected]>
Co-authored-by: glopezdiest <[email protected]>
Co-authored-by: glopezdiest <[email protected]>
Co-authored-by: Blyron <[email protected]>
Co-authored-by: Minokori <[email protected]>
Co-authored-by: AreopagX <[email protected]>
Co-authored-by: Jorge Virgos <[email protected]>
Co-authored-by: Sergio Paniego Blanco <[email protected]>
Co-authored-by: Ylmdrin <[email protected]>
Blyron pushed a commit that referenced this pull request Nov 5, 2024
@AreopagX @Minokori
@Daraan @sergiopaniego @Ylmdrin
Instance segmentation (#8334)
e8947a4 
* added cpp client build docs (#7942)

* fixed IMU units (#7960)

* Update README.md with new TinyURL links (#7988)

* Added inverse transform (#7999)

Co-authored-by: glopezdiest <[email protected]>

* Aaron/fixwheelchair (#8001)

* Fix OSM2ODR build

* Updated fix wheelchair default value

* Docs/unit updates (#8007)

* fixed IMU units

* updated autitwheel version

* Add a `*.pyi` file for auto-completion & hints.

To enable auto-completion and hints in code editors such as VScode, create a `*.pyi` file. This feature is compatible with `python 3.9` and later versions.

* Fixes and missing Iterators

* Fixed Actor.parent

Can be None or an Actor

* Fixed missing return types

* Updated changelog

needs merge with dev version

* Added DSVEventArray iterator

* Added missing type for Labelled Point

* Fixed spelling misstakes

* Removed wrong unit indication

* Added missing -> World to load_world

* Added missing return value to reload_world

* FIX: __init__ methods do not return

* FIX: added ApplyTransform, fixed ApplyTorque

* Filled in missing information and types.

* ActorList.filter actually returns ActorList

* Fixed CityObjectLabels

* Disambiguated get_waypoint signature

Syntax fix (squased)

* Added undocumented variables

FutureActor
laod_world_if_different

* Corrected Sensor.is_listening

Was changed to a function in 0.9.15. More info see: #7439

* Added type hints for `values` attribute on enums

* Fix intendation shadowing methods

* Fix missing @Property

* Formatted some docstring to be shorter

* Added stubs for HUD drawing

Functions from #7168

* Corrected and more precise type-hints

- fixed carla.Waypoint.next_until_lane_end

* Improved get_waypoint disambiguation

correctly added two overload function

* Fix spelling mistakes

* Better usage of Enum if typing.Self is availiable

Using Self will not report an override / incompatible error.

* Fix: Enum values were tuples. Added Flag or Int to Enums

* Fixes for wrong stubs

- OpendriveGenerationParameter had no init
- missing @Property
- wrong signatures

* Added self parameter to property signatures

* Various fixes

- wrong signatures
- wrong names

* Added setters for VehicleControl

* Improved get_waypoints and Literal type hints

* Corrected [try_]spawn_actor keyword name

* Added Transform.inverse_transform and corrected signature

parameter is called in_point not in_vector

* Improved Callable and callbacks signature

* Corrections and additions

more setters
missing, wrong types corrected
spelling

* Fixed Vector arithmetic

* added digital twins video (#8090)

* use actor ids for instance segmentation

* synchronize bboxes between server and client

* add actor_id attribute to bounding boxes

* navigation information is now loaded when changing maps

* Porting the changes done to UE5 to fix the recording leak to UE4

The slowdown is considerably more noticeable here since the engine runs much smoother. This makes evident that this is a stopgap measure, and should be looked into further down the line.

* Fixed typo in CityScapes palette (#8137)

* Correcting makefile typo to avoid override warning for target "downloadplugins" (#8167)

The downloadplugins target is already defined below (line 162).

* fix typo in title (#8225)

* added unreal coord system, fixed v2x (#8251)

---------


Co-authored-by: Minokori <[email protected]>
Co-authored-by: Daniel <[email protected]>
Co-authored-by: Sergio Paniego Blanco <[email protected]>
Co-authored-by: Ylmdrin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blyron Blyron Blyron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glopezdiest @Daraan @Blyron