Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(microsoft-word): add noobieyuh as maintainer #1455

Closed

Conversation

noobieyuh
Copy link
Contributor

I saw the "looking for maintainers" message, and I have decided that I want to become a maintainer for Microsoft Word. Let me know if there's something else I need to do :)

@noobieyuh noobieyuh requested a review from a team as a code owner November 15, 2024 00:56
@uncenter
Copy link
Member

Hi! Glad to hear that you want to become a maintainer for the Microsoft Word userstyle. We typically prefer if maintainers have contributed at least once before, though I know this isn't documented/mentioned in that text you came across. Would you like to take a stab at #1466? For reference on adding options to a userstyle, see the following:

@var checkbox logo "Enable YouTube logo" 1

& when (@logo = 0) {
ytd-topbar-logo-renderer,
svg.ytd-consent-bump-v2-lightbox {
display: none;
}
}

The first is setting the new option variable in the metadata (see https://github.com/openstyles/stylus/wiki/Writing-UserCSS#var for documentation on that syntax), and then the second is using that variable in the userstyle itself. If you have any questions feel free to join the Catppuccin Discord and find us in the #userstyles channel :)

@noobieyuh
Copy link
Contributor Author

Hi! Glad to hear that you want to become a maintainer for the Microsoft Word userstyle. We typically prefer if maintainers have contributed at least once before, though I know this isn't documented/mentioned in that text you came across.

Oh, okay. I understand, that makes sense :)

Would you like to take a stab at #1466?

Yeah, sure! Should I make a new pull request for it?

@uncenter
Copy link
Member

Yes please do! You can find our documentation on contributing at https://github.com/catppuccin/userstyles/blob/main/docs/CONTRIBUTING.md.

@isabelroses isabelroses added the pending Pending due to internal discussion, planned website updates, etc. label Nov 20, 2024
@noobieyuh
Copy link
Contributor Author

My pull request #1468 got approved and merged. Is there anything else I need to do? c:

@uncenter
Copy link
Member

uncenter commented Feb 1, 2025

Hi, sorry it has taken us so long to get back to you! We've reconsidered our position on how to bring in new maintainers and we are now thinking we want to see more continued improvements to the userstyle before we add someone as a maintainer. We've tried to update the documentation as well to make this clear going forward. I noticed quite a few other issues with the Microsoft Word userstyle, so if you are interested in fixing those and submitting some more pull requests we would love to add you as a maintainer!

@uncenter uncenter closed this Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending Pending due to internal discussion, planned website updates, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants