Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: moves learn styling to docs. Replaces unneeded shortcodes with … #1152

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

tnolet
Copy link
Member

@tnolet tnolet commented Dec 11, 2024

…markdown hooks

Affected Components

  • Content & Marketing
  • Pricing
  • Test
  • Docs
  • Learn
  • Other

Pre-Requisites

  • Code is linted (npm run lint)

Notes for the Reviewer

Some Hugo and CSS code changes:

  • Generalizes the code block styling across /docs, /guides and /learn
  • Uses render-hooks for alert blocks. Makes Hugo specific shortcodes for info and warning obsolete.

Some (a lot...) of markdown edits:

  • Adds titles to codeblocks where applicable
  • Replaces all {{< info >}} and {{< warning >}} shortcodes with equivalent markdown >

Screenshots

Titled code blocks 👇

CleanShot 2024-12-11 at 16 38 08@2x

CleanShot 2024-12-11 at 16 38 39@2x

Standard alerts 👇

CleanShot 2024-12-11 at 16 39 35@2x

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
checklyhq-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 6:22pm

Copy link
Contributor

@serverless-mom serverless-mom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great QoL improvement

@tnolet tnolet enabled auto-merge (squash) December 13, 2024 18:21
@tnolet tnolet merged commit 435e937 into main Dec 13, 2024
5 checks passed
@tnolet tnolet deleted the tnolet/move-styles-to-docs-sc00 branch December 13, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants