-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clarification around how group and check configurations interact #1156
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cjanslow do we want to make this callout even more explicit? i.e. adding a bit saying smth along the lines of "This means a check within a group with no connected alert channels will not alert."
Otherwise LGTM already
@ragog Great thought, I made that change as well. Please re-review when you get a chance. |
@cjanslow I highlighted the warnings on both pages in a bit of a different way. Later we might want to take another look at the Groups page in general as it is not CLI-first, but that's a different PR. Could you review? |
@ragog These changes look great, makes the impact a lot more obvious! LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Affected Components