Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarification around how group and check configurations interact #1156

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

cjanslow
Copy link
Contributor

Affected Components

  • Content & Marketing
  • Pricing
  • Test
  • Docs
  • Learn
  • Other

@cjanslow cjanslow requested a review from tnolet as a code owner December 17, 2024 21:07
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
checklyhq-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 11:36am

Copy link
Contributor

@ragog ragog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjanslow do we want to make this callout even more explicit? i.e. adding a bit saying smth along the lines of "This means a check within a group with no connected alert channels will not alert."

Otherwise LGTM already

@cjanslow
Copy link
Contributor Author

@ragog Great thought, I made that change as well. Please re-review when you get a chance.

@ragog
Copy link
Contributor

ragog commented Dec 19, 2024

@cjanslow I highlighted the warnings on both pages in a bit of a different way. Later we might want to take another look at the Groups page in general as it is not CLI-first, but that's a different PR. Could you review?

@cjanslow
Copy link
Contributor Author

@ragog These changes look great, makes the impact a lot more obvious! LGTM

@ragog ragog self-requested a review December 19, 2024 16:30
Copy link
Contributor

@ragog ragog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ragog ragog merged commit 5343ffd into main Dec 19, 2024
6 checks passed
@ragog ragog deleted the cj/group-check-interactions branch December 19, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants