Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videolab #243

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Videolab #243

wants to merge 20 commits into from

Conversation

sanjanag
Copy link
Member

Summary

🎯 Purpose: Describe the objective of your changes in this Pull-Request.

📜 Example Usage: If adding new functionality, strive to provide a minimal working example (MWE) that demonstrates end-to-end usage and output of your new methods. If creating a MWE is not feasible, a conceptual code snippet showcasing the usage is also appreciated. Ensure that the code provided can be copied, pasted, and run without modifications.

[ ✏️ Write your summary here. ]

# Example code snippet

# Necessary Imports:
from my_module import my_new_function

# Setup if needed (e.g., data loading, model instantiation):
a = 20
b = 22

# Usage and Output:
result = my_new_function(a, b)
# 42

# ---- Your code below ----
# [Replace the example above with your own code, ensuring it is executable and demonstrates your feature or fix.]
[your_uncommented_runnable_code_here]
# [your_output_here_as_a_comment]

Impact

🌐 Areas Affected: Enumerate modules, functions, or documentation impacted by your code.

👥 Who’s Affected: Mention who might be impacted (if applicable).

Screenshots

📸 If your changes modify documentation or a tutorial notebook, please include screenshots or GIFs showing the rendered outputs for a quicker initial review, highlighting the main changes.

Testing

🔍 Testing Done: Outline what kinds of tests you performed.

🔗 Test Case Link: Directly link to the most end-to-end check of your new functionality.

Unaddressed Cases

It's ok if your unit tests are not yet
comprehensive when you first open the PR,
we can revisit them later!

⚠️ Mention any aspects of testing that have not been covered, and why.

Links to Relevant Issues or Conversations

🔗 What Git or Slack items (Issues, threads, etc) that are specifically related to
this work? Please link them here.

References

📚 Include any extra information that may be helpful to reviewers of your
Pull-Request here (e.g. relevant URLs or Wiki pages that could help give
background information).

Share links, docs, or sources that facilitated your changes.

If relevant, please include additional code snippets
(and their outputs/return values) showing alternative ways to use your newly added methods.

[additional code snippets and explanations]

Reviewer Notes

💡 Include any specific points for the reviewer to consider during their review.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ sanjanag
❌ Femme Phile


Femme Phile seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 105 lines in your changes are missing coverage. Please review.

Comparison is base (cd8f98b) 95.63% compared to head (0085be5) 87.43%.
Report is 8 commits behind head on main.

Files Patch % Lines
src/cleanvision/videolab.py 28.69% 82 Missing ⚠️
src/cleanvision/dataset/video_dataset.py 48.00% 13 Missing ⚠️
src/cleanvision/utils/frame_sampler.py 33.33% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   95.63%   87.43%   -8.21%     
==========================================
  Files          16       19       +3     
  Lines         986     1146     +160     
  Branches      194      224      +30     
==========================================
+ Hits          943     1002      +59     
- Misses         22      124     +102     
+ Partials       21       20       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants