Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

efi: Improve EFI Compatibility #204

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

retrage
Copy link
Contributor

@retrage retrage commented Oct 22, 2022

This PR improves EFI compatibility to support Linux boot in upcoming aarch64 support tracked in issue #198.

@retrage retrage changed the title efi: Improve EFI Compatibility for aarch64 Boot efi: Improve EFI Compatibility Oct 22, 2022
@retrage retrage requested a review from rbradford October 22, 2022 07:58
@retrage retrage mentioned this pull request Oct 22, 2022
9 tasks
@retrage retrage force-pushed the efi-compatiblity-improvement branch from 685c46b to 4584563 Compare October 23, 2022 08:20
src/efi/block.rs Outdated Show resolved Hide resolved
"win64" ABI is supported by x86_64 only. This change is required to
support other architectures.

Signed-off-by: Akira Moroo <[email protected]>
This commit implements `install_configuration_table()` using
pre-allocated fixed size table. This function is used by aarch64/Linux
boot for registering ACPI or FDT table.

Signed-off-by: Akira Moroo <[email protected]>
@retrage retrage force-pushed the efi-compatiblity-improvement branch from 4584563 to 4fce4d7 Compare October 31, 2022 10:28
@retrage
Copy link
Contributor Author

retrage commented Oct 31, 2022

@rbradford I noticed that the use of eficall!() macro can be replaced with "efiapi" ABI. I pushed this change in a75b253.

@retrage retrage requested a review from rbradford October 31, 2022 11:45
@rbradford
Copy link
Member

@rbradford I noticed that the use of eficall!() macro can be replaced with "efiapi" ABI. I pushed this change in a75b253.

I think that looks a lot nicer! 🚀

@retrage retrage merged commit b40eadd into cloud-hypervisor:main Oct 31, 2022
@retrage retrage deleted the efi-compatiblity-improvement branch October 31, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants