Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add OG image tutorial #19826

Closed
wants to merge 1 commit into from
Closed

Re-add OG image tutorial #19826

wants to merge 1 commit into from

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Feb 7, 2025

Summary

This is a re-addition of #18384, which was removed in #19813. cc @mohdlatif

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@db-cloudflare
Copy link
Contributor

db-cloudflare commented Feb 7, 2025

@mohdlatif Apologies for the inconvenience, this had been published before the technical review was completed. Wrangler doesn't support Bun, which means this tutorial will need to be edited. Would you still be available to make changes to this tutorial so we can republish it?

@cloudflare cloudflare deleted a comment from github-actions bot Feb 7, 2025
return { data, name: font, style, weight };
}

// ... other font loading strategies available in the full source code
Copy link
Contributor

@db-cloudflare db-cloudflare Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohdlatif Another suggestion, readers should be able to create a fully functional app through the tutorial alone. If there are code blocks that are optional to finish the app you can include them under a dropdown, but any code required for the app to function should be displayed in a standard code block

@penalosa penalosa closed this Feb 7, 2025
@mohdlatif
Copy link
Contributor

Absolutely, I will edit it soon and push the changes. But why is it already closed? It's just a small edit—just a few lines. Instead of Bun, the user can use NPM, and it will still work.

@mohdlatif
Copy link
Contributor

#19854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:workers Related to Workers product size/l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants