introduce tx_cap factor #1921
Open
introduce tx_cap factor #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we buffer outgoing data up to `min(cwnd, flow_control)`, but this can be lead to starving a connection while waiting for additional data from the application. This change adds a configuration option to change the send capacity "factor", that is multiplied to the existing send capacity calculation (so e.g. instead of `min(cwnd, flow_control)` once could change that to `2 * min(cwnd, flow_control)`). Making this configurable rather than a fixed value lets application experiment with different values depending on their needs.
ghedo
force-pushed
the
tx-cap-multiplier
branch
from
085daa5 to
bc46b56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we buffer outgoing data up to
min(cwnd, flow_control), but this can be lead to starving a connection while waiting for additional data from the application.This change adds a configuration option to change the send capacity "factor", that is multiplied to the existing send capacity calculation (so e.g. instead of
min(cwnd, flow_control)once could change that to2 * min(cwnd, flow_control)).Making this configurable rather than a fixed value lets application experiment with different values depending on their needs.