Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use qlog PacketSent default inside quiche #1933

Merged
merged 15 commits into from
Feb 5, 2025

Conversation

LPardue
Copy link
Contributor

@LPardue LPardue commented Feb 3, 2025

In followup to #1931, we can cut down on boilerplate internally

@LPardue LPardue requested a review from a team as a code owner February 3, 2025 15:37
@ghedo
Copy link
Member

ghedo commented Feb 4, 2025

AFAICT there are a few more EventData cases in lib.rs, h3/mod.rs and recovery/mod.rs that could also be converted, though not quite as satisfying as these changes, do we want to convert those too while at it?

@LPardue
Copy link
Contributor Author

LPardue commented Feb 4, 2025

commit count 📈

(or more like lets squash these then merge"

@ghedo ghedo merged commit 48c1185 into master Feb 5, 2025
36 checks passed
@ghedo ghedo deleted the lucas/qulog-default-simplify branch February 5, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants