🐞: Allow spaces in app names

This regression was introduced while trying to fix [another
bug](https://www.pivotaltracker.com/story/show/172891571), preventing
users from logging in to spaces containing commas in the name.

Commas should be the only special character requiring double encoding
(per [this documentation](https://github.com/cloudfoundry/cc-api-v3-style-guide#query-parameters),
so we are now using a find replace for commas only.

[finishes #173550835]

Authored-by: Sarah Weinstein <[email protected]>

api/cloudcontroller/ccv3/query.go

@@ -119,7 +119,8 @@ func FormatQueryParameters(queries []Query) url.Values {
 		if query.Key == NameFilter {
 			encodedParamValues := []string{}
 			for _, valString := range query.Values {
-				encodedParamValues = append(encodedParamValues, url.QueryEscape(valString))
+				commaEncoded := strings.ReplaceAll(valString, ",", "%2C")
+				encodedParamValues = append(encodedParamValues, commaEncoded)
 			}
 			query.Values = encodedParamValues
 		}

api/cloudcontroller/ccv3/query_test.go

@@ -36,15 +36,15 @@ var _ = Describe("Query Helpers", func() {
 				inputQueries = []Query{
 					{
 						Key:    NameFilter,
-						Values: []string{"name1", "name,2"},
+						Values: []string{"name1", "name,2", "name 3"},
 					},
 				}
 				outputParameters = FormatQueryParameters(inputQueries)
 			})
 
-			It("encodes the param values before formatting", func() {
+			It("encodes commas before formatting", func() {
 				Expect(outputParameters).To(Equal(url.Values{
-					"names": []string{"name1,name%2C2"},
+					"names": []string{"name1,name%2C2,name 3"},
 				}))
 			})
 		})