Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependent modules to support TF 0.12+ #25

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update dependent modules to support TF 0.12+ #25

wants to merge 3 commits into from

Conversation

Firaenix
Copy link

@Firaenix Firaenix commented Jun 4, 2024

what

  • Updated Null Label module to latest
  • Updated IAM role module to latest
  • Fixed reference to capabilities to be a list, not a string

why

  • Builds using this module werent working on TF 1.8,4

@Firaenix Firaenix requested review from a team as code owners June 4, 2024 10:04
@Firaenix Firaenix requested review from Gowiem and gberenice June 4, 2024 10:04
@mergify mergify bot added the triage Needs triage label Jun 4, 2024
@Gowiem
Copy link
Member

Gowiem commented Jun 4, 2024

/terratest

@Gowiem
Copy link
Member

Gowiem commented Jun 4, 2024

/terratest

@Gowiem
Copy link
Member

Gowiem commented Jun 5, 2024

@Firaenix unfortunately, this module needs to be updated with our testing harness + overall latest practices. We'll need someone from the core or maintainer teams to carve out some time to do that. I'll bring this up, but just an FYI that it may take some time.

@Gowiem Gowiem added the needs-cloudposse Needs Cloud Posse assistance label Jun 5, 2024
@Gowiem Gowiem self-assigned this Jun 5, 2024
@mergify Mergify
Copy link

mergify bot commented Jun 5, 2024

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@Firaenix
Copy link
Author

Firaenix commented Jun 5, 2024

@Firaenix unfortunately, this module needs to be updated with our testing harness + overall latest practices. We'll need someone from the core or maintainer teams to carve out some time to do that. I'll bring this up, but just an FYI that it may take some time.

No skin off my back, I'm just pointing to my fork of it atm. Just thought I'd merge back onto master.

@settings settings bot removed the terraform/1.0 label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@gberenice gberenice Awaiting requested review from gberenice gberenice is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees

@Gowiem Gowiem

Labels
needs-cloudposse Needs Cloud Posse assistance triage Needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Firaenix @Gowiem