Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EN] add Cloud Native Storage #2119

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

[EN] add Cloud Native Storage #2119

wants to merge 17 commits into from

Conversation

manthan-parmar-1998
Copy link

@manthan-parmar-1998 manthan-parmar-1998 commented Jun 8, 2023 •
edited
Loading

Describe your changes

Added New Term - Cloud Native Storage

Related issue number or link (ex: resolves #issue-number)

resolves #2089

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@netlify
Copy link

netlify bot commented Jun 8, 2023 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit b7bceb3
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6781adf8eae052000890fd21
😎 Deploy Preview https://deploy-preview-2119--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the lang/en for English label Jun 8, 2023
@nate-double-u nate-double-u self-requested a review June 12, 2023 19:17
@CathPag
Copy link
Collaborator

CathPag commented Jun 15, 2023

Thanks for your contribution, @Manthan1313Github. We currently have a backlog and not enough people to help with reviews. We'll get to this but we would ask for your patience. Thanks in advance!

@nate-double-u nate-double-u changed the title [EN] Added New Term - Cloud Native Storage [EN] add Cloud Native Storage Jun 19, 2023
@nate-double-u nate-double-u self-assigned this Jul 10, 2023
@nate-double-u nate-double-u removed their assignment Jul 27, 2023
iamNoah1
iamNoah1 requested changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hei @Manthan1313Github and thanks for your contribution. I left some comments :)

content/en/cloud-native-storage.md Outdated Show resolved Hide resolved
content/en/cloud-native-storage.md Outdated Show resolved Hide resolved
content/en/cloud-native-storage.md Outdated Show resolved Hide resolved
content/en/cloud-native-storage.md Outdated Show resolved Hide resolved
content/en/cloud-native-storage.md Outdated Show resolved Hide resolved
content/en/cloud-native-storage.md Outdated Show resolved Hide resolved
content/en/cloud-native-storage.md Outdated Show resolved Hide resolved
content/en/cloud-native-storage.md Outdated Show resolved Hide resolved
content/en/cloud-native-storage.md Show resolved Hide resolved
@manthan-parmar-1998
Copy link
Author

manthan-parmar-1998 commented Jan 31, 2024 •
edited
Loading

@iamNoah1
Thank you for the review. I will start working your comments and will create PR for this. Can you please assign this issue to me. So I can work on the updates.

@iamNoah1
Copy link
Collaborator

iamNoah1 commented Feb 1, 2024

Hei @Manthan1313Github, the issue is already assigned to you :) And there is no to create a new PR you could just follow up your work in this PR. Thanks :)

manthan-parmar-1998 and others added 9 commits February 6, 2024 19:04
@manthan-parmar-1998 @iamNoah1
Update content/en/cloud-native-storage.md
2e071e8 
Remove headline: What it is

Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Manthan Parmar <[email protected]>
@manthan-parmar-1998 @iamNoah1
Update content/en/cloud-native-storage.md
b4dc6f9 
Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Manthan Parmar <[email protected]>
@manthan-parmar-1998 @iamNoah1
Update content/en/cloud-native-storage.md
7c69cef 
Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Manthan Parmar <[email protected]>
@manthan-parmar-1998 @iamNoah1
Update content/en/cloud-native-storage.md
d4b17a6 
Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Manthan Parmar <[email protected]>
@manthan-parmar-1998 @iamNoah1
Update content/en/cloud-native-storage.md
9cc7549 
Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Manthan Parmar <[email protected]>
@manthan-parmar-1998 @iamNoah1
Update content/en/cloud-native-storage.md
599ab76 
Co-authored-by: Noah Ispas <[email protected]>
Signed-off-by: Manthan Parmar <[email protected]>
@manthan-parmar-1998
Merge branch 'cncf:main' into cloud-native-storage-en
30e2a56
@manthan-parmar-1998
Merge branch 'cncf:main' into cloud-native-storage-en
2c80893
@manthan-parmar-1998
Update cloud-native-storage.md
bc7c9e3 
Implemented suggested changes.

Signed-off-by: Manthan Parmar <[email protected]>
manthan-parmar-1998
manthan-parmar-1998 commented Aug 15, 2024
View reviewed changes
Copy link
Author

@manthan-parmar-1998 manthan-parmar-1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented suggested changes.

@iamNoah1
Copy link
Collaborator

Thanks @manthan-parmar-1998 looks good for me, lets get second review :)

@github-actions GitHub Actions
Copy link

To see where this is in the review pipeline and follow the progress, please look at the definition review board.

nate-double-u
nate-double-u requested changes Nov 1, 2024
View reviewed changes
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @manthan-parmar-1998. I have some comments and suggestions below.

content/en/cloud-native-storage.md Outdated Show resolved Hide resolved
content/en/cloud-native-storage.md Outdated Show resolved Hide resolved
content/en/cloud-native-storage.md Outdated Show resolved Hide resolved
@iamNoah1
Copy link
Collaborator

friendly ping @manthan-parmar-1998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caniszczyk caniszczyk Awaiting requested review from caniszczyk caniszczyk is a code owner

@CathPag CathPag Awaiting requested review from CathPag

@JasonMorgan JasonMorgan Awaiting requested review from JasonMorgan

@seokho-son seokho-son Awaiting requested review from seokho-son seokho-son is a code owner

@jihoon-seo jihoon-seo Awaiting requested review from jihoon-seo jihoon-seo is a code owner

@castrojo castrojo Awaiting requested review from castrojo castrojo is a code owner

@iamNoah1 iamNoah1 Awaiting requested review from iamNoah1 iamNoah1 is a code owner

@nate-double-u nate-double-u Awaiting requested review from nate-double-u nate-double-u is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@nate-double-u nate-double-u

Labels
lang/en for English Tech review 1 ✅
Projects
CNCF glossary definition review board
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cloud Native Storage
4 participants
@manthan-parmar-1998 @CathPag @iamNoah1 @nate-double-u