Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export_ply.h - fix compiler error regarding lvalue requirement #235

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brandonw3612
Copy link

@brandonw3612 brandonw3612 commented Apr 16, 2024

Thank you for sending a Pull Request to the VCGLib!

Check the PR branch!

On this repository, we keep two relevant branches:

  • main: we keep here the last release version of VCGLib, with just bugfixes. In case of serious bugs caught after a release, this branch is used to publish "post-releases".
  • devel: we add here new features and functionalities of the library that are going to appear in the next release of VCGLib. Bugfixes pushed in main are automatically merged on the devel branch.

Before submitting a PR, please check which branch suits better for your contribution!

CLA

VCGLib is fully owned by CNR, and all the VCGLib contributors that do not work at the VCLab of CNR must first sign the contributor license agreement that you can find at the following link: https://github.com/cnr-isti-vclab/vcglib/blob/devel/docs/ContributorLicenseAgreement.pdf

If you will sign the CLA, then we will be able to merge your pull request after reviewing it.
The validity of the CLA is two years, therefore after signing it your PRs for the next two years can be merged without further actions.
Please send the signed document to [email protected] and [email protected] .
If you will not sign the CLA, we will review and then apply your changes as soon as possible.

Before opening the PR, please leave the following form with a check for your particular case:

Check with [x] what is your case:
  • I already signed and sent via email the CLA;
  • I will sign and send the CLA via email as soon as possible;
  • I don't want to sign the CLA.

@brandonw3612
Copy link
Author

This should have been fixed in commit 0a2ed11 along with several lines that followed, but somehow it was not 🤔.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant