[render] update readme and change vclib-3rd-bgfx property dir

cnr-isti-vclab · Oct 25, 2024 · ba5b111 · ba5b111
1 parent 0269e22
commit ba5b111
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/vclib/render/3rdparty/bgfx.cmake b/vclib/render/3rdparty/bgfx.cmake
@@ -44,7 +44,7 @@ if (VCLIB_ALLOW_BUNDLED_BGFX AND EXISTS ${VCLIB_BGFX_DIR})
     target_include_directories(vclib-3rd-bgfx
         INTERFACE ${VCLIB_BGFX_DIR}/bgfx/3rdparty)
 
-    set_target_properties(vclib-3rd-bgfx PROPERTIES BGFX_DIR ${VCLIB_BGFX_DIR})
+    set_target_properties(vclib-3rd-bgfx PROPERTIES BGFX_CMAKE_DIR "${VCLIB_BGFX_DIR}/cmake")
 
     list(APPEND VCLIB_RENDER_3RDPARTY_LIBRARIES vclib-3rd-bgfx)
 elseif(VCLIB_ALLOW_BUNDLED_BGFX)

diff --git a/vclib/render/CMakeLists.txt b/vclib/render/CMakeLists.txt
@@ -51,7 +51,7 @@ endforeach()
 
 # if render engine is bgfx - include sources that use bgfx
 if (VCLIB_RENDER_BACKEND STREQUAL "bgfx")
-    get_target_property(VCLIB_BGFX_DIR vclib-3rd-bgfx BGFX_DIR)
+    get_target_property(VCLIB_BGFX_CMAKE_DIR vclib-3rd-bgfx BGFX_CMAKE_DIR)
     include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/bgfx_config.cmake)
 
     file(GLOB_RECURSE HEADERS_BGFX CONFIGURE_DEPENDS

diff --git a/vclib/render/cmake/bgfx_config.cmake b/vclib/render/cmake/bgfx_config.cmake
@@ -20,7 +20,7 @@
 #* (https://www.mozilla.org/en-US/MPL/2.0/) for more details.                *
 #****************************************************************************/
 
-include(${VCLIB_BGFX_DIR}/cmake/bgfxToolUtils.cmake)
+include(${VCLIB_BGFX_CMAKE_DIR}/bgfxToolUtils.cmake)
 
 function(_set_bgfx_profiles)
     set(GLSL_PROFILE 140 PARENT_SCOPE)

diff --git a/vclib/render/todo.md b/vclib/render/todo.md
@@ -1,13 +1,16 @@
 # VCLib-Render ToDo list
 
 - General
-    - [ ] qt headers and sources should be moved into vclib/processing/qt inside this module,
-      and should be included only if vclib-processing target is available
-    - [x] Manage polygonal meshes by DrawableMesh
-    - [x] Fix build failure when the build directory is in the same directory as the source
+  - [ ] qt headers and sources should be moved into vclib/processing/qt inside this module,
+    and should be included only if vclib-processing target is available
+  - [x] Manage polygonal meshes by DrawableMesh
+  - [x] Fix build failure when the build directory is in the same directory as the source
+  - [ ] Add the possibility to check if BGFX is available in the system
+    - [ ] Devcontainers should have BGFX installed
+  - [ ] Move BGFX from submodule to a CMake dependency
 - BGFX
   - [x] Library shaders should be built as headers
-  - [ ] Check why OpenGL backend does not work
+  - [ ] Check why OpenGL backend does not work when using BGFX (probably the cause is BGFX itself)
   - [ ] assets and shaders should be compiled in headers that are in paths like
     'vclib/assets/' and 'vclib/shaders/' (right now they are in 'assets/' and 'shaders/')
   - [x] the first window used by the context to create the bgfx backend context should be