-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add box2d JSB codes to engine. #18090
Conversation
|
@dogodo-cc 模块裁剪多份配置功能做好,麻烦说下,我需要处理设置box2d jsb为默认值。 |
refer to #18053 |
Please fix ESLint error as possible. Should ignore it explicitly if can not be fixed. |
cc.config.json
Outdated
@@ -105,9 +105,6 @@ | |||
"physics-2d-box2d-wasm": { | |||
"modules": ["physics-2d-box2d-wasm", "physics-2d-framework"] | |||
}, | |||
"physics-2d-box2d-jsb": { | |||
"modules": ["physics-2d-box2d-jsb", "physics-2d-framework"] | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dogodo-cc Confirmed with dogodo, it should not be added to cc.config.json, which will cause an error while open project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What kinds of error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codes have been recovered.
@dogodo-cc 1.在编写box2d-jsb过程中,在编辑器环境中hack一部分代码,具体:在global-exports,声明了box2d-jsb需要用的方法和类。这样项目才能被编辑器正常打开 2.在多平台配置功能时,也要考虑这种情况的处理方式。具体在哪里实现可以和引擎组沟通。3.做完相关功能后,麻烦提醒下我核对下。 |
external libray: |
new pr is #18152 |
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: