Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add box2d JSB codes to engine. #18090

Closed
wants to merge 17 commits into from
Closed

Conversation

tangkaikk
Copy link
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Copy link

github-actions bot commented Dec 27, 2024

⚠️ Package size ⤴ 32188 bytes, old: 5272212, new: 5304400

Interface Check Report

This pull request does not change any public interfaces !

@tangkaikk
Copy link
Contributor Author

tangkaikk commented Dec 27, 2024

image
image
性能对比图

@tangkaikk
Copy link
Contributor Author

tangkaikk commented Dec 27, 2024

@dogodo-cc 模块裁剪多份配置功能做好,麻烦说下,我需要处理设置box2d jsb为默认值。

@tangkaikk
Copy link
Contributor Author

refer to #18053

@minggo
Copy link
Contributor

minggo commented Dec 30, 2024

Please fix ESLint error as possible. Should ignore it explicitly if can not be fixed.

cc.config.json Outdated
@@ -105,9 +105,6 @@
"physics-2d-box2d-wasm": {
"modules": ["physics-2d-box2d-wasm", "physics-2d-framework"]
},
"physics-2d-box2d-jsb": {
"modules": ["physics-2d-box2d-jsb", "physics-2d-framework"]
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dogodo-cc Confirmed with dogodo, it should not be added to cc.config.json, which will cause an error while open project.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kinds of error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codes have been recovered.

@tangkaikk
Copy link
Contributor Author

tangkaikk commented Jan 9, 2025

@dogodo-cc 1.在编写box2d-jsb过程中,在编辑器环境中hack一部分代码,具体:在global-exports,声明了box2d-jsb需要用的方法和类。这样项目才能被编辑器正常打开 2.在多平台配置功能时,也要考虑这种情况的处理方式。具体在哪里实现可以和引擎组沟通。3.做完相关功能后,麻烦提醒下我核对下。

@tangkaikk
Copy link
Contributor Author

tangkaikk commented Jan 9, 2025

external libray:
refer to #cocos/cocos-engine-external#469
refer to #cocos/cocos-engine-external#470
refer to #cocos/cocos-engine-external#471

@tangkaikk tangkaikk closed this by deleting the head repository Jan 10, 2025
@tangkaikk tangkaikk mentioned this pull request Jan 10, 2025
6 tasks
@tangkaikk
Copy link
Contributor Author

new pr is #18152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants