-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebGPU BindGroupLayout data structures #18136
Conversation
👍 Package size ⤵ -1196 bytes, old: 5272276, new: 5271080Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -8539,8 +8539,14 @@
INT = 4,
UFLOAT = 5,
FLOAT = 6
}
+ export enum SampleType {
+ FLOAT = 0,
+ UNFILTERABLE_FLOAT = 1,
+ SINT = 2,
+ UINT = 3
+ }
export enum Type {
UNKNOWN = 0,
BOOL = 1,
BOOL2 = 2,
@@ -8621,8 +8627,22 @@
CUBE = 3,
TEX1D_ARRAY = 4,
TEX2D_ARRAY = 5
}
+ export enum ViewDimension {
+ UNKNOWN = 0,
+ BUFFER = 1,
+ TEX1D = 2,
+ TEX1D_ARRAY = 3,
+ TEX2D = 4,
+ TEX2D_ARRAY = 5,
+ TEX2DMS = 6,
+ TEX2DMS_ARRAY = 7,
+ TEX3D = 8,
+ TEXCUBE = 9,
+ TEXCUBE_ARRAY = 10,
+ RAYTRACING_ACCELERATION_STRUCTURE = 11
+ }
export enum TextureUsageBit {
NONE = 0,
TRANSFER_SRC = 1,
TRANSFER_DST = 2,
@@ -9347,10 +9367,14 @@
binding: number;
descriptorType: DescriptorType;
count: number;
stageFlags: ShaderStageFlags;
+ access: MemoryAccess;
+ viewDimension: ViewDimension;
+ sampleType: SampleType;
+ format: Format;
immutableSamplers: Sampler[];
- constructor(binding?: number, descriptorType?: DescriptorType, count?: number, stageFlags?: ShaderStageFlags, immutableSamplers?: Sampler[]);
+ constructor(binding?: number, descriptorType?: DescriptorType, count?: number, stageFlags?: ShaderStageFlags, access?: MemoryAccess, viewDimension?: ViewDimension, sampleType?: SampleType, format?: Format, immutableSamplers?: Sampler[]);
copy(info: Readonly<DescriptorSetLayoutBinding>): DescriptorSetLayoutBinding;
}
export class DescriptorSetLayoutInfo {
bindings: DescriptorSetLayoutBinding[];
@@ -29232,8 +29256,9 @@
name: string;
type: gfx.Type;
count: number;
stageFlags: gfx.ShaderStageFlags;
+ sampleType: gfx.SampleType;
}
export interface ISamplerInfo {
set: number;
binding: number;
@@ -29247,8 +29272,9 @@
name: string;
type: gfx.Type;
count: number;
stageFlags: gfx.ShaderStageFlags;
+ sampleType: gfx.SampleType;
}
export interface IBufferInfo {
binding: number;
name: string;
@@ -35829,22 +35855,8 @@
TEXTURE1D = 1,
TEXTURE2D = 2,
TEXTURE3D = 3
}
- export enum ViewDimension {
- UNKNOWN = 0,
- BUFFER = 1,
- TEX1D = 2,
- TEX1DARRAY = 3,
- TEX2D = 4,
- TEX2DARRAY = 5,
- TEX2DMS = 6,
- TEX2DMSARRAY = 7,
- TEX3D = 8,
- TEXCUBE = 9,
- TEXCUBEARRAY = 10,
- RAYTRACING_ACCELERATION_STRUCTURE = 11
- }
export enum ResourceFlags {
NONE = 0,
UNIFORM = 1,
INDIRECT = 2,
|
Please fix errors reported by clang tidy as possible. |
|
@cocos-robot run test cases |
@star-e, Please check the result of
Task Details |
@star-e, Please check the result of
Task Details |
It seems this function |
Immutable Samplers is not used in gfx. It is only supported in vulkan. |
Got it. |
Add data structures for WebGPU BindGroupLayout
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: