Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "add builtin pipeline passes (#17985)" #18278

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

star-e
Copy link
Contributor

@star-e star-e commented Feb 5, 2025

This reverts commit aa3b926.

We need to move PipelineSettings component to the engine, to support version migration.

And this will be a paradigm shift from current pipeline architecture.

More research should be done before supporting builtin pipeline components.

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@star-e
Copy link
Contributor Author

star-e commented Feb 5, 2025

@cocos-robot run test cases

Copy link

github-actions bot commented Feb 5, 2025

✅ Package size is not changed

Interface Check Report

This pull request does not change any public interfaces !

Copy link

github-actions bot commented Feb 5, 2025

@star-e, Please check the result of run test cases:

Task Details

Copy link

github-actions bot commented Feb 5, 2025

@star-e, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS PASS
android PASS PASS PASS
wechatgame PASS FAIL FAIL

@star-e star-e requested a review from minggo February 6, 2025 02:02
@star-e star-e merged commit 4a88af7 into cocos:v3.8.6 Feb 6, 2025
13 checks passed
@star-e star-e deleted the v3.8.6-revert branch February 6, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants