-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more feature cropping settings for RichText, Mask, Graphics, UISkew, AffineTransform. #18284
base: v3.8.6
Are you sure you want to change the base?
Conversation
…ew, AffineTransform.
|
@cocos-robot run test cases |
1 similar comment
@cocos-robot run test cases |
@cocos-robot run test cases |
1 similar comment
@cocos-robot run test cases |
this._world.SetDebugDraw(debugDraw); | ||
} catch (e: any) { | ||
errorID(4501, e.message as string); | ||
node.destroy(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to set node to null too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
this._b2DebugDrawer = debugDraw; | ||
this._world.SetDebugDraw(debugDraw as B2.Draw); | ||
} catch (e: any) { | ||
errorID(4501, e.message as string); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should destroy node here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
Code updated.
…86-feature-cropping-more
…86-feature-cropping-more
@cocos-robot run test cases |
Re: #18222
New settings:
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: