-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent - Token required because branch is protected #1580
Comments
Workaround is to close the PR and make a new one e.g. opensearch-project/opensearch-migrations#1019 |
I'm getting this quite a lot suddenly on https://github.com/google/osv-scanner - this only started happening in the last couple of weeks and afaik there have not been any changes to the branch protection rules (@another-rex could you confirm this?) Some action examples: |
@thomasrockhu can you please look into this one? 🙏 |
@thomasrockhu-codecov seems to be a better handle to ping :) |
@greg0ire @AndreKurait noting that I see this. Am asking the team what the expected behavior is but from what I can tell, we have always had protected branches require a token. @AndreKurait have you seen this come up again or was it that one time? |
@G-Rath please let me know if there was a change in branch protection rules |
@thomasrockhu-codecov I don't know as I'm not the owner of the repository, but I've not seen this failure for a few weeks so I assume it's just been fixed 🤷 |
@thomasrockhu-codecov I no longer see the _error message on my repository, but I still have an issue: the upload is never processed. I will file a separate bug report. |
Here it is: #1633 |
Going to close this one out for now, @greg0ire I'll take a look at that issue |
@thomasrockhu-codecov I just hit this again, can we reopen this? I only ever get it after pushing multiple commits after creating a PR. It appears to be a bug in detecting the fork
|
It's inconsistent because another action on the same commit passed
|
@AndreKurait got it, taking a look |
@thomasrockhu-codecov Not sure if would help but wanted to share that we are seeing this issue too. No branch projection has been added. The first commit passes diffpy/diffpy.utils@87a5b6d, but when a new commit (diffpy/diffpy.utils@f45ba82) is added, it starts to fail with the message. |
This one is really strange, I'm syncing with the product team to try to understand why this is happening. That said, we are planning to release action@v5 in the next 2 weeks (likely next week) which SHOULD fix this issue too. |
Leaving a tasklist of some issues/PRs that will mitigate/fix the issue
|
@bobleesj @AndreKurait we pushed a different change from the tasklist above that I think will solve a race condition we were having. Can you see if this issue is still happening? |
@thomasrockhu-codecov Thanks! Yup will do. |
@AndreKurait everything ok? I got a message in my email and just wanted to double-check |
We had some failures tonight with a new error message.
Made some PRs which passed, and some failed. I have a suspicion there's some throttling limits involved, so i set up some actions to retry 20 times, and observed this error message occur consistently. I looked into our use of tokens, and saw we were triggering our action on |
found it |
@AndreKurait we pushed a fix for this earlier today, can you try again? |
@thomasrockhu-codecov just wanted to share we've had no issues so far, around 3-4 PRs across 2-3 repos since then. |
This comment has been minimized.
This comment has been minimized.
This is still broken for me
Full output
|
On a public repo, i'm getting inconsistent results with codecov-v4
e.g. opensearch-project/opensearch-migrations#1016
First Run - Successful
Subsequent Run - Failure
The text was updated successfully, but these errors were encountered: