Update development dependencies #969
Open
+3,614
−2,983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
commented
Mar 22, 2024
| @@ -43,24 +43,22 @@ | |||
| "walk-sync": "^2.2.0" | |||
| }, | |||
| "devDependencies": { | |||
| "chai": "^4.3.4", | |||
| "@release-it-plugins/lerna-changelog": "^6.1.0", | |||
| "chai": "^4.4.1", | |||
There was a problem hiding this comment.
Latest v4, because v5 is pure ESM.
| "mockery": "^2.1.0", | ||
| "nyc": "^15.1.0", | ||
| "prettier": "^2.4.1", | ||
| "release-it": "^14.11.6", | ||
| "release-it-lerna-changelog": "^3.1.0", |
There was a problem hiding this comment.
Renamed to @release-it-plugins/lerna-changelog.
| "eslint-plugin-node": "^11.1.0", | ||
| "eslint-plugin-prettier": "^3.1.4", | ||
| "glob": "^7.2.0", |
| "eslint-plugin-node": "^11.1.0", | ||
| "eslint-plugin-prettier": "^3.1.4", | ||
| "glob": "^7.2.0", | ||
| "json": "^10.0.0", |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #969 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 18 18
Lines 532 532
=======================================
Hits 504 504
Misses 28 28 ☔ View full report in Codecov by Sentry. |
kategengler
approved these changes
Mar 22, 2024
|
Reviewed this during the weekly tooling meeting. The blocker is the remaining test failure. |
|
Closing, due to lack of time. |
bertdeblock
force-pushed
the
update-dev-deps
branch
from
4de6a0f
to
7730df0
Compare
bertdeblock
force-pushed
the
update-dev-deps
branch
from
7730df0
to
067e1df
Compare
kategengler
reviewed
Nov 11, 2024
| fail_ci_if_error: true | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| run: yarn node-test | ||
| # run: yarn node-test-with-coverage |
There was a problem hiding this comment.
I think enable this but put if: github.event_name == 'push'
And a comment with this link codecov/codecov-action#1580 so we know to re-enable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.