-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup IP address tracking for sentry user #2945
base: main
Are you sure you want to change the base?
Conversation
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 4097 tests with View the full list of failed tests
|
1 similar comment
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 4097 tests with View the full list of failed tests
|
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 3571 tests with View the full list of failed tests
|
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 4097 tests with View the full list of failed tests
|
Bundle ReportChanges will decrease total bundle size by 15 bytes ⬇️
|
Bundle ReportChanges will decrease total bundle size by 15 bytes ⬇️
|
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 4694 tests with
View the full list of failed tests
|
Description
This PR closes codecov/engineering-team#1663.
It should update the sentry user object to store IP as per https://docs.sentry.io/platforms/javascript/enriching-events/identify-user/#ip_address.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.