feat(syncactions): add support for apiextensions, businessunits and subscriptions #1909
Conversation
🦋 Changeset detectedLatest commit: e0b9064 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1909 +/- ##
==========================================
+ Coverage 94.63% 94.70% +0.06%
==========================================
Files 147 153 +6
Lines 5070 5134 +64
Branches 1379 1379
==========================================
+ Hits 4798 4862 +64
Misses 269 269
Partials 3 3 ☔ View full report in Codecov by Sentry. |
|
fixes #1808 |
| { | ||
| action: 'changeAssociate', | ||
| associate: { customer: { id: 'new', typeId: 'customer' } }, | ||
| }, |
There was a problem hiding this comment.
If this is a new associate why is being treated as a changeAssociate?
There was a problem hiding this comment.
It is a bit of a chicken--egg problem.
create-build-array-actions is comparing two objects and believes a change is ok.
Since we are having add, remove and change as update actions I am not sure what would be a better approach.
Summary
Adding additonal, missing sync actions
Description
We were missing some sync actions in our nodejs library for now. Added apiextensions, businessunits and subscriptions.
Todo
Typelabel for the PR